Differences

This shows you the differences between two versions of the page.

Link to this comparison view

irc:1490396400 [2017/05/27 13:44] (current)
Line 1: Line 1:
 +[12:23:50] *** ChanServ sets mode: +o temporalfox
 +
 +[15:26:12] <​ivanovdns>​ hi there
 +
 +[15:26:26] <​ivanovdns>​ could someone help with line endings on windows..
 +
 +[15:27:12] <​ivanovdns>​ I'm trying to test a project created somewhere and all fails cause file contents \r\n instead of \n
 +
 +[15:27:34] <​ivanovdns>​ event if I deliberately switch mode to LF in idea
 +
 +[15:47:38] <​AlexLehm>​ ivanovdns: the files may be created with the "​native"​ line endings, but read as bytes streams, if the project only works in linux, that requires some fixing in windows
 +
 +[16:03:53] <​ivanovdns>​ so.. is it mean that I should only change a reading method of such files? Because if I change line endings in IDEA it shows me a difference between a new version of a file and a repo version. Actually a diff tool shows nothing
 +
 +[16:04:17] <​ivanovdns>​ Thank Alex.. look deeper about it
 +
 +[16:06:11] <​ivanovdns>​ AlexLehm: could you please run a build for a pull request
 +
 +[16:07:01] <​AlexLehm>​ i did, https://​vertx.ci.cloudbees.com/​view/​All/​job/​ivanovdns-vertx-web/​3/​
 +
 +[16:07:47] <​ivanovdns>​ I made some fixes just a few minutes ago
 +
 +[16:07:59] <​AlexLehm>​ ah ok
 +
 +[16:09:52] <​AlexLehm>​ https://​vertx.ci.cloudbees.com/​view/​All/​job/​ivanovdns-vertx-web/​4/​console
 +
 +[16:11:05] <​ivanovdns>​ ok, crossed fingers ))
 +
 +[16:11:15] <​AlexLehm>​ actually i think you could define a ping url so that the build is triggered in jenkins when you push to your repo directly
 +
 +[16:14:04] <​ivanovdns>​ looks fine for template engines :)
 +
 +[16:15:09] <​AlexLehm>​ ok, that build worked
 +
 +[16:16:05] <​ivanovdns>​ about run build by myself.. I don't have a permission I think.. There is no button for it in the left menu as I can see in my local jenkins environment..
 +
 +[16:17:09] <​AlexLehm>​ you can define a push webhook in the github settings with https://​vertx.ci.cloudbees.com/​github-webhook/,​ then its possible to trigger the build even though you only have readonly access to the jenkins
 +
 +[16:18:02] <​AlexLehm>​ you should be able to run a mvn build in a local jenkins though
 +
 +[16:19:49] *** ChanServ sets mode: +o temporalfox
 +
 +[16:29:29] <​AlexLehm>​ ivanovdns: i think i have an example in the vertx code somewhere of a test that failed in windows and required some tweaking with eol
 +
 +[16:34:09] <​AlexLehm>​ not quite sure where though
 +
 +[16:34:43] <​ivanovdns>​ I reverted all changes after tests. Actually I have a problems with all of them. I changed eol manually. But it was not helped with Thymeleaf test. There is an html template file and \r exists even after changing to LF from CRLF.
 +
 +[16:36:22] <​ivanovdns>​ I saw an advise for converting line endings with git commit but only for phpstorm.. Don't see it for IDEA
 +
 +[16:37:13] <​ivanovdns>​ trying this: https://​help.github.com/​articles/​dealing-with-line-endings/​
 +
 +[16:41:26] <​AlexLehm>​ which project are you working on? a vertx one?
 +
 +[16:48:30] <​ivanovdns>​ this one: https://​github.com/​ivanovdns/​vertx-web
 +
 +[16:54:42] <​AlexLehm>​ ah ok
 +
 +[16:54:54] <​AlexLehm>​ i think i didn't try to run the unit tests in windows yet
 +
 +[17:14:20] <​AlexLehm>​ when I run the template tests in the vertx-web project, everything passes, however I have checked out the git with LF endings
 +
 +[17:14:33] <​AlexLehm>​ some other tests fails though in windows
 +
 +[17:46:47] <​ivanovdns>​ Yes, it passes if a template does not have line breaks.
 +
 +[18:54:35] *** ChanServ sets mode: +o temporalfox