Differences

This shows you the differences between two versions of the page.

Link to this comparison view

irc:1476050400 [2017/05/27 13:44]
irc:1476050400 [2017/05/27 13:44] (current)
Line 1: Line 1:
 +[11:04:47] <​ppatiern>​ temporalfox:​ Hi !
 +
 +[11:04:58] <​temporalfox>​ hi ppatiern
 +
 +[11:05:56] <​ppatiern>​ temporalfox:​ in order to start using Vert.x MQTT server in the Eclipse Hono project I need a snapshot published somewhere ... is it possible ?
 +
 +[11:06:35] <​temporalfox>​ I think it should be in maven sonatype oss repository
 +
 +[11:07:02] <​temporalfox>​ it's not actually
 +
 +[11:07:13] <​temporalfox>​ it should be by cloudbess ci
 +
 +[11:08:13] <​temporalfox>​ checking
 +
 +[11:08:20] <​temporalfox>​ it was never built ocrre tly
 +
 +[11:08:38] <​temporalfox>​ ah ok I see
 +
 +[11:08:43] <​temporalfox>​ https://​vertx.ci.cloudbees.com/​job/​vert.x3-mqtt-server/​3/​console
 +
 +[11:08:45] <​temporalfox>​ I will update the project
 +
 +[11:08:50] <​temporalfox>​ to extend vertx ext parent
 +
 +[11:08:54] <​temporalfox>​ that's the reason
 +
 +[11:08:59] <​temporalfox>​ is that ok with you ?
 +
 +[11:09:25] <​ppatiern>​ sorry I don't understand the reason :-)
 +
 +[11:10:08] <​ppatiern>​ ah ok I see something missing in my POM about deployment
 +
 +[11:10:28] <​ppatiern>​ can you address it for me ?
 +
 +[11:12:23] <​temporalfox>​ yes
 +
 +[11:12:24] <​temporalfox>​ will do
 +
 +[11:15:10] <​ppatiern>​ thanks ! ;)
 +
 +[11:15:25] <​ppatiern>​ can you ping me when it's done I can refer it from Hono  please ?
 +
 +[11:16:57] <​temporalfox>​ yes
 +
 +[11:17:04] <​temporalfox>​ how is going the implementation by the way ?
 +
 +[11:17:44] <​ppatiern>​ about the MQTT server ?
 +
 +[11:17:52] <​temporalfox>​ yes
 +
 +[11:18:14] <​ppatiern>​ I'm just starting to use it in Hono ... feedback will come in next days :-)
 +
 +[11:18:34] <​temporalfox>​ running tests I get
 +
 +[11:18:36] <​temporalfox>​ Oct 10, 2016 11:17:58 AM io.vertx.core.impl.ContextImpl
 +
 +[11:18:36] <​temporalfox>​ SEVERE: Unhandled exception
 +
 +[11:18:37] <​temporalfox>​ java.lang.NullPointerException
 +
 +[11:18:37] <​temporalfox>​ at io.vertx.core.net.impl.ConnectionBase.handleException(ConnectionBase.java:​188)
 +
 +[11:18:39] <​temporalfox>​ at io.vertx.core.net.impl.VertxHandler.lambda$exceptionCaught$0(VertxHandler.java:​85)
 +
 +[11:18:39] <​temporalfox>​ at io.vertx.core.impl.ContextImpl.lambda$wrapTask$2(ContextImpl.java:​322)
 +
 +[11:18:41] <​temporalfox>​ at io.vertx.core.impl.ContextImpl.executeFromIO(ContextImpl.java:​190)
 +
 +[11:18:41] <​temporalfox>​ at io.vertx.core.net.impl.VertxHandler.exceptionCaught(VertxHandler.java:​78)
 +
 +[11:18:49] <​temporalfox>​ unsubscribe(io.vertx.mqtt.test.MqttUnsubscribeTest) ​ Time elapsed: 0.01 sec  <<<​ FAILURE!
 +
 +[11:18:51] <​temporalfox>​ is it expected ?
 +
 +[11:19:06] <​ppatiern>​ nope
 +
 +[11:19:12] <​ppatiern>​ it never happened to me ... strange
 +
 +[11:19:16] <​ppatiern>​ let me check
 +
 +[11:19:29] <​temporalfox>​ I'm rerunning
 +
 +[11:19:45] <​temporalfox>​ I'm changing version to 3.4.0-SNAPSHOT as well
 +
 +[11:19:58] <​ppatiern>​ ok
 +
 +[11:20:05] <​ppatiern>​ just run no errors on TEST
 +
 +[11:20:13] <​temporalfox>​ ok
 +
 +[11:20:15] <​temporalfox>​ weird
 +
 +[11:20:22] <​temporalfox>​ I will push and let's see what happens in CI
 +
 +[11:20:25] <​ppatiern>​ I'll check the test case ... any possible race conditions ?
 +
 +[11:20:30] <​ppatiern>​ ok thanks
 +
 +[11:21:32] <​temporalfox>​ I don't know
 +
 +[11:21:43] <​temporalfox>​ maybe a port conflict on my machine
 +
 +[11:22:29] <​temporalfox>​ if you need snapshot and it does not run then you need to fix that or comment the test (bad :-) )
 +
 +[11:22:49] <​ppatiern>​ of course
 +
 +[11:23:31] <​ppatiern>​ I see the NullPointerException even here
 +
 +[11:23:31] <​ppatiern>​ https://​vertx.ci.cloudbees.com/​job/​vert.x3-mqtt-server/​4/​testReport/​junit/​io.vertx.mqtt.test/​MqttUnsubscribeTest/​unsubscribe/​
 +
 +[11:23:43] <​temporalfox>​ it fails
 +
 +[11:23:44] <​temporalfox>​ https://​vertx.ci.cloudbees.com/​job/​vert.x3-mqtt-server/​4/​console
 +
 +[11:24:23] <​ppatiern>​ let me dig into it
 +
 +[11:24:30] <​ppatiern>​ I'll ping you ... thanks !
 +
 +[11:24:41] <​ppatiern>​ strange it doesn'​t happen here on my PC :-(
 +
 +[11:30:32] <​temporalfox>​ you can try to fix it and push in initial work branch
 +
 +[11:30:34] <​temporalfox>​ it will run CI
 +
 +[11:30:37] <​temporalfox>​ and you can see the result
 +
 +[11:30:40] <​ppatiern>​ ok
 +
 +[11:30:42] <​ppatiern>​ right
 +
 +[11:30:52] <​temporalfox>​ MVC style
 +
 +[11:34:42] <​ppatiern>​ temporalfox ... I see this line in the handleException inside ConnectionBase
 +
 +[11:34:48] <​ppatiern>​ metrics.exceptionOccurred(metric(),​ remoteAddress(),​ t);
 +
 +[11:35:06] <​ppatiern>​ but metric() return null in my MqttConnection implementation for now
 +
 +[11:35:13] <​ppatiern>​ this is the NullPointerException
 +
 +[11:35:17] <​temporalfox>​ comment it for now
 +
 +[11:35:25] <​ppatiern>​ the test ?
 +
 +[11:46:19] <​ppatiern>​ this is the only thing I can do now before adding metrics to MQTT server
 +
 +[11:46:48] <​temporalfox>​ the metric thing
 +
 +[11:47:13] <​temporalfox>​ I will have probably some refactoring to do at some point
 +
 +[11:47:21] <​temporalfox>​ to make this easy
 +
 +[11:48:10] <​ppatiern>​ ok
 +
 +[11:49:47] <​ppatiern>​ does it work on CI using @Ignore for my test and having one Skipped ?
 +
 +[12:02:55] <​ppatiern>​ temporalfox ignoring the test works for now ... the snapshot was published
 +
 +[12:05:21] <​temporalfox>​ ok
 +
 +[12:50:59] <​davsclaus>​ does vert.x have any health check OOTB ?
 +
 +[18:53:50] <​temporalfox>​ davsclaus do you mean something to implemnet health check in an application ?
 +
 +[18:54:24] <​davsclaus>​ @temporalfox yes, like /health does in spring boot
 +
 +[18:54:35] <​davsclaus>​ and something that is easy for vert.x end users to turn on / enable
 +
 +[18:54:54] <​davsclaus>​ and that it returns HTTP 200 when vert.x is ready to service traffic
 +
 +[18:55:42] <​temporalfox>​ so you mean built-in endpoints ?
 +
 +[18:55:51] <​davsclaus>​ ideally yes
 +
 +[18:56:02] <​temporalfox>​ we don't have at the moment I think
 +
 +[18:56:03] <​davsclaus>​ but eventually also so you can add custom health checks
 +
 +[18:56:12] <​temporalfox>​ clement is looking at this specific area
 +
 +[18:56:17] <​temporalfox>​ yes that would be great
 +
 +[18:56:18] <​davsclaus>​ ah awesome
 +
 +[18:57:37] <​temporalfox>​ imho it would be easy with the notion of vertx service