Differences

This shows you the differences between two versions of the page.

Link to this comparison view

irc:1472853600 [2017/05/27 13:44] (current)
Line 1: Line 1:
 +[15:32:04] <​AlexLehm>​ temporal_: I have found an issue with a rather odd combination of socks proxy and ssl and implemented a fix, depending on whether there is time left for the next release, we could include that or leave it for the next version since it is not likely to affect anyone
 +
 +[15:32:08] <​temporal_>​ hi AlexLehm
 +
 +[15:32:12] <​AlexLehm>​ Hi Julien
 +
 +[15:32:20] <​AlexLehm>​ https://​github.com/​eclipse/​vert.x/​pull/​1604
 +
 +[15:32:25] <​temporal_>​ release is supposed to happen early next week
 +
 +[15:32:31] <​temporal_>​ so there is still time to review
 +
 +[15:32:36] <​temporal_>​ and add it
 +
 +[15:32:47] <​AlexLehm>​ ok, its a very small fix, if you could review it
 +
 +[15:33:08] <​temporal_>​ yes sure
 +
 +[15:35:30] <​AlexLehm>​ ok, that would be great thanks
 +
 +[20:11:31] <​myghty>​ AlexLehm: thanks for the headsup, was away over the last day :)
 +
 +[20:11:41] <​myghty>​ but will have a look later on at your suggestions
 +
 +[20:12:20] <​AlexLehm>​ if it still doesn'​t work, it would be best if you could put up a stripped down project that shows the issue
 +
 +[20:12:42] <​AlexLehm>​ i find that sometimes vert.x is a bit difficult to debug with exceptions etc
 +
 +[20:13:58] <​myghty>​ funny thing is: it used to work at one point... I just dunno at which of my commits that was exactly... ;D should apply the best practice of keeping unit tests green to my private projects as well before commiting