This version (2017/05/27 13:44) is a draft.
Approvals: 0/1

[01:13:40] * ChanServ sets mode: +o temporalfox [10:03:55] <paulbakker> Trying to test the “invalid-http-response” branch but getting a build error: [10:04:00] <paulbakker> [ERROR] /Users/paulb/repo/vertx/vert.x/src/main/java/io/vertx/core/impl/AddressResolver.java:[56,28] incompatible types: bad return type in method reference io.netty.channel.socket.nio.NioDatagramChannel cannot be converted to ? extends io.netty.channel.socket.DatagramChannel [INFO] 1 error [10:04:23] <paulbakker> seems unrelated to the branch, any ideas? [10:05:42] <pmlopes> that looks like a mismatch between source/jar versions [10:06:25] <temporalfox> paulbakker you need to use Netty 4.1.0.Final [10:06:26] <temporalfox> wondering why this would happen [10:06:35] <temporalfox> perhaps java version ? [10:06:42] <temporalfox> java compiler version [10:07:23] <paulbakker> java version “1.8.0_31” Java(TM) SE Runtime Environment (build 1.8.0_31-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.31-b07, mixed mode) [10:08:13] <paulbakker> i didn't touch the pom files, so the netty version etc. should be ok [10:08:25] <paulbakker> it's literally a clean git clone [10:10:18] <temporalfox> ok [10:10:28] <temporalfox> can you try with a more recent version ? [10:10:32] <temporalfox> 31 is quite old [10:10:53] <temporalfox> this is raise problem [10:10:55] <temporalfox> builder.channelFactory(NioDatagramChannel::new) [10:11:00] <temporalfox> I think I can change that though [10:11:15] <temporalfox> try to change this line with [10:11:16] <temporalfox> builder.channelType(NioDatagramChannel.class) [10:11:46] <temporalfox> I think we can change that [10:13:56] <paulbakker> builds after changing that line [10:14:09] <paulbakker> I'll undo the change and try with the latest jdk8 as well [10:18:45] <paulbakker> builds with 1.8.0_91 without problem [10:18:52] <paulbakker> thanks for the hint [10:21:06] <temporalfox> paulbakker n/p [11:20:17] * ChanServ sets mode: +o temporalfox

[12:18:37] <temporalfox> paulbakker I commited the change for the AddressResolver

[13:00:06] <paulbakker> temporalfox nice!

[13:12:22] * ChanServ sets mode: +o temporalfox [13:20:52] <gemmellr> pmlopes: temporalfox: I'm going to prepare a change around my most recent comments on the PR [13:21:37] <pmlopes> ok, i've added the proton connection to the init, i can push it righ now if you want [13:22:54] <gemmellr> ah, that woudl be great :) [13:23:34] <pmlopes> done [13:25:00] <pmlopes> gemmellr: i am just not sure of one thing, you're saying that init should take (ProtonConnection, NetSocket, Transport)? or just (ProtonConnection, Transport)? [13:25:19] <gemmellr> pmlopes: the former [13:25:33] <pmlopes> ok, i'll update in a sec [13:26:15] <gemmellr> either that, or instead of the socket, a boolean indicating SSL and a copy of the peer cert [13:28:39] <pmlopes> i'd say the socket so even if it is ssl you can verify the CA, certificates, etc… (full control) [13:28:47] <gemmellr> pmlopes: the issue being, I might not want my custom authenticator to offer e.g PLAIN if it isnt using SSL, and wouldnt want it to offer EXTERNAL if knowing they dont have a cert to use it with [13:28:56] <gemmellr> pmlopes: yes, and its simpler :) [13:33:24] <pmlopes> gemmellr: it is there with (NetSocket, ProtonConnection, Transport), 1st arg vertx related, remaining proton [13:35:59] <gemmellr> pmlopes: great, ill take a look [14:06:16] * ChanServ sets mode: +o temporalfox

[14:40:36] <AlexLehm> paulbakker: temporalfox: I came accross this issue as well on a CI service that had java 1.8.0 installed, I think to compile correctly it needs about 1.8.0 >40

[14:57:57] <gemmellr> pmlopes: do you mind if i push my test changes on to the branch you made for the PR?

[15:01:29] <pmlopes> of course not

[15:01:58] <gemmellr> pmlopes: great, will do so now