Differences

This shows you the differences between two versions of the page.

Link to this comparison view

irc:1462140000 [2017/05/27 13:44] (current)
Line 1: Line 1:
 +[21:36:59] <​AlexLehm>​ i have a question that is more a git question, how do I copy a branch from another repo to my own fork to a new branch name
 +
 +[21:37:07] <​AlexLehm>​ or should I do this differently
 +
 +[21:44:57] <​aesteve>​ never tried to, but : configure upstream, git fetch upstream, git checkout -b theNewBranchName upstream/​branchName,​ work, git commit -a -m "my work", git push origin theNewBranchName
 +
 +[21:45:46] <​aesteve>​ git push -u origin theNewBranchName,​ according to : http://​stackoverflow.com/​questions/​4410091/​github-import-upstream-branch-into-fork
 +
 +[21:46:21] <​aesteve>​ didnt know about the -u stuff
 +
 +[21:51:27] <​aesteve>​ temporal_: thanks for reporting the issues on my repo
 +
 +[21:52:00] <​aesteve>​ don't mind the metaclass stuff, the purpose was to explain the solution "next to the problem"​
 +
 +[21:52:23] <​aesteve>​ obviously the correct implementation would be using groovy default extensions
 +
 +[21:52:53] <​kuwv>​ Anyone here can answer some web related vertx questions?
 +
 +[21:53:46] <​aesteve>​ kuwv: depends on the question ;) but give it a try
 +
 +[21:57:42] <​AlexLehm>​ aesteve: thanks, i did it like that (currently looking at a branch Julien made for the proxy stuff)
 +
 +[22:02:19] <​aesteve>​ np AlexLehm Github has a ton of good wikis on how to deal with remotes (origins / upstream / forks from other people / ...). I think the first time I really understood how remotes are working is when I tried to review someones'​ pull request locally
 +
 +[22:39:14] <​temporal_>​ AlexLehm ​ hi
 +
 +[22:39:31] <​AlexLehm>​ hi Julien
 +
 +[22:39:56] <​temporal_>​ how is it going ?
 +
 +[22:40:17] <​AlexLehm>​ good this evening
 +
 +[22:40:37] <​AlexLehm>​ I have taken a look at the proxy code, that looks ok to me
 +
 +[22:40:53] <​temporal_>​ yes we have made good progress on this
 +
 +[22:41:05] <​temporal_>​ we need to resolve the DNS question still :-)
 +
 +[22:42:05] <​AlexLehm>​ for the proxy code its easy now I think
 +
 +[22:43:26] <​temporal_>​ it's possibleto resolve a DNS address without doing a channel connection
 +
 +[22:43:28] <​temporal_>​ too
 +
 +[22:43:33] <​temporal_>​ with VertxInternal
 +
 +[22:43:46] <​AlexLehm>​ would it make sense to create a utility function to create a InetSocketAddress with the dns client in vertx?
 +
 +[22:44:18] <​temporal_>​ it is possible to create an already resolved InetSocketAddress I think
 +
 +[22:44:31] <​AlexLehm>​ yes it is
 +
 +[22:44:31] <​temporal_>​ that's the main problem ?
 +
 +[22:44:57] <​AlexLehm>​ its not really a problem, I assume if we need this in other places, it might make sense to have it as a util function
 +
 +[22:45:11] <​AlexLehm>​ i can implement it in the proxy code first
 +
 +[22:45:41] <​temporal_>​ yes rather there
 +
 +[22:45:57] <​temporal_>​ and we need also documentation / example
 +
 +[23:28:58] <​AlexLehm>​ the InetSocketAddress can be created like this https://​github.com/​alexlehm/​vert.x/​tree/​julien%231361